Basic ของการแกะลูปนรก

type SalesPerson = {
  name: string;
  level: "junior" | "senior";
  contracts: Contract[]; // มีหลายสัญญา
};

type Contract = {
  // Field อื่นๆ
  hasBonus: true;
  bonusCommission: number;
};

type SalesLine = {
  productCode: string;
  amount: number;
  price: number;
  totalPrice: number;
};

function calculateCommission(
  salesPerson: SalesPerson,
  lines: SalesLine[],
  specialProductCodes: string[]
) {
  let totalCommission;
  for (const line of lines) {
    const price = line.amount;
    let commission = 0;
    if (salesPerson.level === "junior") {
      commission = price * 0.05;
    } else {
      commission = price * 0.07;
    }
    for (const specialCode of specialProductCodes) {
      if (line.productCode === specialCode) {
        commission = price * 0.2;
      }
    }
    for (const contract of salesPerson.contracts) {
      if (contract.hasBonus) {
        commission *= 1 + contract.bonusCommission;
      }
    }
    totalCommission += commission;
  }
  if (totalCommission > 200000) {
    totalCommission *= 1.03;
  }
  return totalCommission;
}

export type SalesPerson = {
  name: string;
  level: "junior" | "senior";
  contracts: Contract[]; // มีหลายสัญญา
};

export type Contract = {
  // Field อื่นๆ
  hasBonus: boolean;
  bonusCommission: number;
};

export type SalesLine = {
  productCode: string;
  totalPrice: number;
};

function extractLineWithSpecialProduct(
  lines: SalesLine[],
  specialProductCodes: string[]
) {
  const specialProductLines: SalesLine[] = [];
  const otherProductLines: SalesLine[] = [];
  for (const line of lines) {
    if (specialProductCodes.includes(line.productCode)) {
      specialProductLines.push(line);
    } else {
      otherProductLines.push(line);
    }
  }
  return [specialProductLines, otherProductLines];
}

export function calculateCommission(
  salesPerson: SalesPerson,
  lines: SalesLine[],
  specialProductCodes: string[]
): number {
  let totalCommission = 0;
  let totalAmount = 0;

  // แยกส่วนว่าอันไหนเป็นตัวพิเศษ
  const [specialProductLines, normalProductLines] =
    extractLineWithSpecialProduct(lines, specialProductCodes);

  // คิดเฉพาะเคสพิเศษ
  for (const line of specialProductLines) {
    const price = line.totalPrice;
    totalAmount += price;
    let commission = price * 0.2;

    for (const contract of salesPerson.contracts) {
      if (contract.hasBonus) {
        commission += price * contract.bonusCommission;
      }
    }

    totalCommission += commission;
  }

  // คิดเฉพาะเคสปกติ
  for (const line of normalProductLines) {
    const price = line.totalPrice;
    totalAmount += price;
    let commission = 0;
    if (salesPerson.level === "junior") {
      commission = price * 0.05;
    } else {
      commission = price * 0.07;
    }
    for (const contract of salesPerson.contracts) {
      if (contract.hasBonus) {
        commission += price * contract.bonusCommission;
      }
    }
    totalCommission += commission;
  }
  if (totalAmount >= 200000) {
    totalCommission *= 1.1;
  }
  return Math.round(totalCommission);
}

export type SalesPerson = {
  name: string;
  level: "junior" | "senior";
  contracts: Contract[]; // มีหลายสัญญา
};

export type Contract = {
  // Field อื่นๆ
  hasBonus: boolean;
  bonusCommission: number;
};

export type SalesLine = {
  productCode: string;
  totalPrice: number;
};

function extractLineWithSpecialProduct(
  lines: SalesLine[],
  specialProductCodes: string[]
) {
  const specialProductLines: SalesLine[] = [];
  const otherProductLines: SalesLine[] = [];
  for (const line of lines) {
    if (specialProductCodes.includes(line.productCode)) {
      specialProductLines.push(line);
    } else {
      otherProductLines.push(line);
    }
  }
  return [specialProductLines, otherProductLines];
}

function specialCommission(line: SalesLine, salesPerson: SalesPerson) {
  const price = line.totalPrice;
  let commission = price * 0.2;

  for (const contract of salesPerson.contracts) {
    if (contract.hasBonus) {
      commission += price * contract.bonusCommission;
    }
  }
  return commission;
}

function normalCommission(line: SalesLine, salesPerson: SalesPerson) {
  const price = line.totalPrice;
  let commission = 0;
  if (salesPerson.level === "junior") {
    commission = price * 0.05;
  } else {
    commission = price * 0.07;
  }
  for (const contract of salesPerson.contracts) {
    if (contract.hasBonus) {
      commission += price * contract.bonusCommission;
    }
  }
  return commission;
}

export function calculateCommission(
  salesPerson: SalesPerson,
  lines: SalesLine[],
  specialProductCodes: string[]
): number {
  let totalCommission = 0;
  let totalAmount = 0;

  // แยกส่วนว่าอันไหนเป็นตัวพิเศษ
  const [specialProductLines, normalProductLines] =
    extractLineWithSpecialProduct(lines, specialProductCodes);

  // คิดเฉพาะเคสพิเศษ
  for (const line of specialProductLines) {
    totalAmount += line.totalPrice;
    totalCommission += specialCommission(line, salesPerson);
  }

  // คิดเฉพาะเคสปกติ
  for (const line of normalProductLines) {
    totalAmount += line.totalPrice;
    totalCommission += normalCommission(line, salesPerson);
  }
  if (totalAmount >= 200000) {
    totalCommission *= 1.1;
  }
  return Math.round(totalCommission);
}

export type SalesPerson = {
  name: string;
  level: "junior" | "senior";
  contracts: Contract[]; // มีหลายสัญญา
};

export type Contract = {
  // Field อื่นๆ
  hasBonus: boolean;
  bonusCommission: number;
};

export type SalesLine = {
  productCode: string;
  totalPrice: number;
};

function extractLineWithSpecialProduct(
  lines: SalesLine[],
  specialProductCodes: string[]
) {
  const specialProductLines: SalesLine[] = [];
  const otherProductLines: SalesLine[] = [];
  for (const line of lines) {
    if (specialProductCodes.includes(line.productCode)) {
      specialProductLines.push(line);
    } else {
      otherProductLines.push(line);
    }
  }
  return [specialProductLgines, otherProductLines];
}

function applyBonusContract(
  originalCommission: number,
  price: number,
  salesPerson: SalesPerson
) {
  let commission = originalCommission;
  for (const contract of salesPerson.contracts) {
    if (contract.hasBonus) {
      commission += price * contract.bonusCommission;
    }
  }
  return commission;
}

function specialCommission(line: SalesLine, salesPerson: SalesPerson) {
  const price = line.totalPrice;
  let commission = price * 0.2;

  commission = applyBonusContract(commission, price, salesPerson);
  return commission;
}

function normalCommission(line: SalesLine, salesPerson: SalesPerson) {
  const price = line.totalPrice;
  let commission = 0;
  if (salesPerson.level === "junior") {
    commission = price * 0.05;
  } else {
    commission = price * 0.07;
  }

  commission = applyBonusContract(commission, price, salesPerson);
  return commission;
}

export function calculateCommission(
  salesPerson: SalesPerson,
  lines: SalesLine[],
  specialProductCodes: string[]
): number {
  let totalCommission = 0;
  let totalAmount = 0;

  // แยกส่วนว่าอันไหนเป็นตัวพิเศษ
  const [specialProductLines, normalProductLines] =
    extractLineWithSpecialProduct(lines, specialProductCodes);

  // คิดเฉพาะเคสพิเศษ
  for (const line of specialProductLines) {
    totalAmount += line.totalPrice;
    totalCommission += specialCommission(line, salesPerson);
  }

  // คิดเฉพาะเคสปกติ
  for (const line of normalProductLines) {
    totalAmount += line.totalPrice;
    totalCommission += normalCommission(line, salesPerson);
  }

  if (totalAmount >= 200000) {
    totalCommission *= 1.1;
  }
  return Math.round(totalCommission);
}

for (const element of list) {
  if (condition(element)) {
    // ทำอะไรที่ซับซ้อน ลูปข้างใน if ข้างในอีกเยอะ
  } else {
    // ทำอีกอย่างนึงที่ซับซ้อนพอกัน
  }
}

const listToDoThisThing = []
const listToDoThatThing = []
for (const elemet of list) {
  if (condition(element)) {
    listToDoThisThing.push(element)
  } else {
    listToDoThatThing.push(element)
  }
}

for (const element of listToDoThisThing) {
 // ทำอะไรที่ซับซ้อน ลูปข้างใน if ข้างในอีกเยอะ
}

for (const element of listToDoThatThing) {
 // ทำอีกอย่างนึงที่ซับซ้อนพอกัน
}